Add velocity_smoother support#115
Open
sskorol wants to merge 1 commit into
Open
Conversation
CullenSUN
reviewed
Feb 13, 2023
gyiptgyipt
reviewed
May 15, 2024
gyiptgyipt
left a comment
gyiptgyipt
left a comment
There was a problem hiding this comment.
suggesting to use DeclareLaunchArgument in launch file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it a draft for now. We can proceed with this as soon as we merge velocity_smoother.
@grassjelly @Tiryoh @CullenSUN feel free to review.
Tested on MiniPupper:
mp_humble_first_walk.mp4