Repository navigation
test: accept readonly render output from pi 1.6.0 components - #223
Open
SpiGAndromeda wants to merge 1 commit into
Open
SpiGAndromeda wants to merge 1 commit into
SpiGAndromeda wants to merge 1 commit into
Conversation
pi-tui 1.6.0 changed `Component.render()` to return `readonly string[]`. The test helpers declared a mutable `string[]` return, so they no longer accepted real components and the current-pi compatibility check failed to typecheck. The helpers in `model-groups-tui.test.ts`, `render-snapshots.test.ts`, `spawn-render.test.ts` and `helpers.ts` now take `readonly string[]`, which the `string[]` returned by the pinned 1.2.0 still satisfies.
Unit test coverage
Coverage per file (52)
Commit c3be193, attempt 1 of the workflow run; the HTML report is in that attempt's coverage artifact. |
grzegorznowak
approved these changes
Nov 20, 2026
grzegorznowak
left a comment
Collaborator
There was a problem hiding this comment.
awesome thanks a tonne!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pi 1.6.0 changed
Component.render()to returnreadonly string[], which broke the typecheck of the current-pi compatibility job: test helpers that expect a mutablestring[]no longer accept real components. The helpers now takereadonly string[], which the pinned 1.2.0 still satisfies.pi 1.6.0 check
The 1.5.2 to 1.6.0 diffs of the published
pi-coding-agent,pi-tui,pi-aiandpi-agent-corepackages and thepi-coding-agentchangelog were checked against what the extension uses. Apart from the render type, pi 1.6.0 needs no change. These are the changes that could have reached the extension:pi-agent-coreno longer stops the tool loop on abort. Every remaining call gets an "Operation aborted" error result and skips thetool_callhook. A probe on 1.2.0 and 1.6.0 returned identical spawn results for aborted child agents (outcome, result text, stats). For the handoff, the same probe showed the same decline, no cut and no refusal left over for the next prompt on both versions; only theturn_endevents differ, with more tool results and anabortedinstead of anerroroutcome.session_start:AgentSession.reload()now re-emits it for hosts bound withbindExtensions({}), and RPC session replacement no longer runs it twice. The extension's handler is safe to run again and keeps no run counter.entry_appendedfor entries added duringsession_start. No e2e test asserts on stderr, and the onlyentry_appendedcount is the one for the handoff cut entry.visibleWidth,truncateToWidthandsliceByColumngot faster paths. 1.5.2 and 1.6.0 returned identical output for a set of test strings covering ANSI styling, box drawing, CJK, emoji and the status glyphs of the spawn and model-group renderers.pi-coding-agent(dist/index.d.ts) is unchanged, andtypeboxstays at 1.3.27.node scripts/test-compat-current.mjspasses at 1.6.0, with the unit and e2e projects.