refactor/amount-numeric - Store financial amounts as NUMERIC#1
Open
chuks68 wants to merge 1 commit into
Open
Conversation
chuks68
force-pushed
the
refactor/amount-numeric
branch
from
9fc83c4 to
fc027bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The amount column in the Position, ExtraDeposit, and Vault models was previously a String, causing type-mismatch bugs and requiring runtime casts to NUMERIC for every calculation. This PR migrates those columns to NUMERIC(38, 18), updates the corresponding CRUD logic to operate on native Decimal values, adds an Alembic migration to perform the schema change safely, and adjusts test expectations.