Fix release pipeline dependency blockers - #189
Merged
Merged
Conversation
The Release workflow has failed on every tag since v1.0.4, so v1.0.5 through v1.0.7 were tagged but never published. Two gates were failing: - postinstall (tsc -b) hit TS2345 in eslint.config.ts. eslint 9.39.5 widened EcmaVersion to include 17, which typescript-eslint 8.22.0's ConfigWithExtends does not accept. Bumped typescript-eslint to 8.67.0 and pinned both so the pair cannot drift apart again. - pnpm audit --prod --audit-level=high flagged two high advisories in react-router (GHSA-chx6-hx7r-mcp5, GHSA-qwww-vcr4-c8h2). Raised the react-router-dom floor to ^7.18.2. The type error stayed invisible locally because tsc -b is incremental and a stale tsconfig.tsbuildinfo skipped the rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release workflow has failed on every tag since v1.0.4.
v1.0.5,v1.0.6andv1.0.7are tagged and pushed, but no GitHub Release was ever created for them, so the Releases page still shows v1.0.4 as latest.Two gates were failing.
postinstall→tsc -b(broke v1.0.6, v1.0.7)eslint9.39.5 widenedEcmaVersionto include17;typescript-eslint8.22.0'sConfigWithExtendsstill expects the narrower union, andeslint.config.tsspreadsreactPlugin.configs.flat.recommendedstraight intots.config(). Both were on carets, so the lockfile drifted into an incompatible pair. Bumpedtypescript-eslintto 8.67.0 and dropped the carets on both so they cannot drift apart again.This never showed up locally because
tsc -bis incremental — a staletsconfig.tsbuildinfoskipped the rebuild.tsc -b --forcereproduced it on a dev machine.pnpm audit --prod --audit-level=high(broke v1.0.5)Two high advisories in
react-router, viapages/popup > react-router-dom:Raised the
react-router-domfloor to^7.18.2.Verification
Ran the full release job locally:
tsc -b --forcepnpm audit --prod --audit-level=highpnpm turbo readypnpm lint:checkpnpm type-checkpnpm testpnpm builddistpnpm -F zipper zipNote this also unblocks the
Testworkflow, which has been red onmainsince the same dependency drift.Once merged, the three missed releases still need backfilling — the workflow only fires on
push: tags: v*, so the existing tags will not re-run on their own.