Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

Fix Android build, clang-tidy crashes, and header includes - #3

Draft
aarvsn wants to merge 1 commit into
mainfrom
jules-3024040393316088289-40540833
Draft

Fix Android build, clang-tidy crashes, and header includes#3
aarvsn wants to merge 1 commit into
mainfrom
jules-3024040393316088289-40540833

Conversation

@aarvsn

@aarvsn aarvsn commented Aug 16, 2026

Copy link
Copy Markdown
Member

Fixed all CI errors across Android build, clang-tidy, and missing includes:

  1. Moved CMake path and version from defaultConfig to android.externalNativeBuild in android/app/build.gradle.kts.
  2. Updated .clang-tidy check order to properly disable checks causing clang-tidy-18 ExceptionSpecAnalyzer crashes.
  3. Added missing header includes for common.hpp and PPUDisassembler.hpp.

PR created automatically by Jules for task 3024040393316088289 started by @aarvsn

…udes

- Move CMake path and version configuration to android.externalNativeBuild.cmake in android/app/build.gradle.kts.
- Re-order check exclusions in .clang-tidy to disable ExceptionSpecAnalyzer noexcept checks after wildcard rules.
- Add missing header includes across Capstone.hpp, MemoryConstants.hpp, CrashAnalyzer.hpp, FragmentInstruction.hpp, and RSXShaderOpcodes.hpp.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant