fix: close theme dropdown when clicking outside the menu#245
Open
toufiq00007 wants to merge 1 commit into
Open
fix: close theme dropdown when clicking outside the menu#245toufiq00007 wants to merge 1 commit into
toufiq00007 wants to merge 1 commit into
Conversation
Contributor
|
@toufiq00007 is attempting to deploy a commit to the Sunil Kumar's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the Theme selection dropdown menu would remain open even after a user clicked outside of its container.
I implemented a React custom outside-click handler using
useRefand a global event listener inside auseEffecthook. Now, clicking anywhere outside the theme menu seamlessly closes it, improving the overall user experience and interface navigation.Changes Made
themesRefusing React'suseRefhook onto the outer container wrapper of the Theme section inTopnavDashboard.jsx.handleClickOutsidelistener within auseEffecthook to detect clicks outside the wrapper.showThemesstate back tofalsewhen an external click is detected.How to Test
Checklists
closes #239