Install a built tarball, so the vignette is actually installed - #30
Merged
Conversation
vignette("datamatch") came back empty after every rebuild. The script
ran `R CMD INSTALL` on the source directory, and installing a directory
copies the .Rmd without building the vignette index, so nothing is
registered.
`--build-vignettes` is not the fix: it belongs to R CMD build, and
R CMD INSTALL answers "unknown option" and carries on succeeding. That
was worth finding out rather than assuming, since the run reported
success either way.
So the script now builds a tarball once and installs that into each R.
Slower by the length of a build, and the only way the index reaches the
library.
Vignettes need pandoc, which is often only present on a Mac as the copy
RStudio bundles, so that is added to PATH when nothing else provides
one. Without pandoc the build retries with --no-build-vignettes rather
than failing: an installed package without a vignette beats no installed
package, and it says which happened.
Verified: vignette("datamatch") now resolves in both R 4.6.1 and 4.3.2.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vignette("datamatch")came back empty after every rebuild, in both R installs.install_all.shranR CMD INSTALLon the source directory, and installing a directory copies the.Rmdwithout building the vignette index — so nothing is registered.--build-vignettesis not the fixIt belongs to
R CMD build.R CMD INSTALLanswers:and carries on succeeding. I tried it first and it appeared to work — the script reported success and the vignette was still missing. Worth finding out rather than assuming.
What the script does now
Builds a tarball once, installs that into each R. Slower by the length of a build, and the only way the index reaches the library.
Vignettes need pandoc, which on a Mac is often only present as the copy RStudio bundles, so that is added to
PATHwhen nothing else provides one. Without pandoc the build retries with--no-build-vignettesrather than failing — an installed package without a vignette beats no installed package — and says which happened.Verified
R CMD check— Status: OK, 778 tests, vignette rebuilding cleanly.🤖 Generated with Claude Code