fix(validator): pin buildtools test image to index digest + bump chart#319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin the
buildtoolstest-hook image in the validator chart.Why
templates/tests/test-logs.yamlhardcodesghcr.io/chronicleprotocol/buildtools:sha-c670bbf(a chronicle image on a bare git-sha tag) in its two helm-test pods. A fullhelm templaterender-sweep ofcharts+charts-internalfound this was the only remaining unpinned chronicle image after the chart-default pin sweep (every other chart's chronicle images are digest-pinned). It's test-only, but the gate renders it, so validator could not passchronicle-image-pin-gateuntil it was pinned.How
Pin both occurrences to
@sha256:ea8bf30723df3e8c0724aa081a6b3f31df072d0da7645f024db3627c7decb1ed(crane-verified multi-arch OCI index). Bump chart0.6.7 -> 0.6.8.With this, all chronicle images across both chart repos are digest-pinned -- the precondition for promoting
chronicle-image-pin-gateto a required check.