Skip to content

[ENH]: Don't resize during hnsw load #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanketkedia merged 2 commits into from
Aug 28, 2025
Merged

[ENH]: Don't resize during hnsw load #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c334d7a
reduce default max elements to 100
sanketkedia Aug 27, 2025
60b674f
disallow setting max_elements during load
sanketkedia Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/hnsw.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,6 @@ pub struct HnswIndex {
unsafe impl Sync for HnswIndex {}
unsafe impl Send for HnswIndex {}

pub const DEFAULT_MAX_ELEMENTS: usize = 10000;

pub struct HnswIndexLoadConfig {
pub distance_function: HnswDistanceFunction,
pub dimensionality: i32,
Expand Down Expand Up @@ -224,7 +222,7 @@ impl HnswIndex {
let path = CString::new(path).map_err(|e| HnswInitError::InvalidPath(e.to_string()))?;

unsafe {
load_index(ffi_ptr, path.as_ptr(), true, true, DEFAULT_MAX_ELEMENTS);
load_index(ffi_ptr, path.as_ptr(), true, true, 0);
}
read_and_return_hnsw_error(ffi_ptr)?;

Expand Down Expand Up @@ -378,7 +376,7 @@ impl HnswIndex {
read_and_return_hnsw_error(ffi_ptr)?;

unsafe {
load_index_from_hnsw_data(ffi_ptr, load_data.ffi_ptr, DEFAULT_MAX_ELEMENTS);
load_index_from_hnsw_data(ffi_ptr, load_data.ffi_ptr, 0);
}
read_and_return_hnsw_error(ffi_ptr)?;

Expand Down
Loading