Reconnect to z2m websocket everytime the service fails#147
Open
duvholt wants to merge 2 commits intochrivers:masterfrom
Open
Reconnect to z2m websocket everytime the service fails#147duvholt wants to merge 2 commits intochrivers:masterfrom
duvholt wants to merge 2 commits intochrivers:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if the z2m service failed it would just stop and never restart. This can be reproduced by restarting z2m (at least that's what happens when I restart z2m in my k8s cluster).
I don't think the z2m service change is controversial, but I also changed the default behavior for services to retry forever. I'm not sure if that can cause issues for some other services, but I haven't personally had any issues with that change.