Skip to content

fix accessibility of case structs #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christiandaley merged 2 commits into from
Aug 9, 2026
Merged

fix accessibility of case structs #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5805884
fix accessibility of case structs
christiandaley Aug 9, 2026
5fd0371
small change
christiandaley Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions SumSharp.Generator/SymbolHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,9 +452,7 @@ public SymbolHandler(
}
else
{
var parsedTypeArguments = TypeNameParser.ExtractLeafTypes(caseData.TypeInfo.Name);

var caseStructTypeArguments = TypeArguments.Intersect(parsedTypeArguments).ToArray();
var caseStructTypeArguments = TypeArguments.Intersect(TypeNameParser.ExtractLeafTypes(caseData.TypeInfo.Name)).ToArray();

var caseStructTypeConstraints =
caseStructTypeArguments
Expand Down Expand Up @@ -836,14 +834,14 @@ private void EmitFieldsAndConstructor()
{
Builder.AppendLine($@"
///<summary>Used to implement .NET 11 union requirements. Use this type when pattern matching using C#'s built-in switch statement</summary>
public readonly partial record struct {caseData.Name};");
{Accessibility} readonly partial record struct {caseData.Name};");
}
else
{
Builder.AppendLine($@"
///<summary>Used to implement .NET 11 union requirements. Use this type when pattern matching using C#'s built-in switch statement</summary>
{GeneratedCodeAttribute}
public readonly record struct {Net11StructNameMap[caseData].NameWithTypeArgs}({caseData.TypeInfo.Name} Value) {Net11StructNameMap[caseData].Constraints};");
{Accessibility} readonly record struct {Net11StructNameMap[caseData].NameWithTypeArgs}({caseData.TypeInfo.Name} Value) {Net11StructNameMap[caseData].Constraints};");
}
}

Expand Down
Loading