Repository navigation
Reject stalled input probes and incomplete benchmark runs - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller input helper could hang indefinitely when a FIFO existed without a reader, despite its requested timeout. It now bounds the connection wait while preserving blocking command writes after connection.
The benchmark could also append a successful CSV row when the runner exited during settling or partway through measurement. It now checks the runner throughout both intervals, reports its exit status and rejects incomplete runs.
Validation: both failures reproduced before the fixes; eight real-FIFO/synthetic-runner regressions pass under Apple Python 3.9, along with source bootstrap and the complete repository suite. No runtime or player defaults change. The remaining timing fields, traversal routes and physical gameplay checks stay open; no performance improvement is claimed.