Repository navigation
Fix fresh checkout player checks for iPhone module recipes - #152
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkout-mode player checks call
builddirectly, so a fresh PadMint folder has none of the recipe’s tools installed. Recipes usingios_modulealso require an explicit compatible base app, which the wrapper could not pass. SunPad #57 exposed both failures before compilation.Install the selected checkout target’s tools inside the same empty PadMint folder before building, and accept an optional fifth base-app path. The published-release path still uses
make; Apple’s Python and the fresh source checkout remain unchanged.Validation: all 333 tests pass with Apple Python 3.9, including five shell integration fixtures covering tool installation order, shared fresh home, absolute and relative app paths with spaces and shell metacharacters, failure propagation, no-app checkout mode, and the published-release path.
bash -nandgit diff --checkpass. A fresh SunPad 81a66cb player check subsequently passed end to end using merged PadMint main 7758cf4, Apple Python 3.9.6 and an empty PadMint folder. The build and independent package readback are recorded in chrissotraidis/sunpad#57; physical-device acceptance remains separate. All ten CI checks passed for this PR.