Allow multiple ProductSupply tags, contributor statements to be an array, allow further lookups for ProductFormFeature#5
Open
conatus wants to merge 14 commits intochrisribal:masterfrom
Open
Conversation
conatus
changed the title
conatus
changed the title
Forked library has details in Composer
Add Stock class for displaying stock
…_identifiers allow multiple workIdentifiers
|
@chrisribal could you please have a look at this PR? We ran into an issue with the ProductFormFeature CodeLists aswell which should be fixed by 50e4b9f. |
add website to contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks so much for creating this library.
When parsing an Onix feed, we have multiple
<productsupply>tags. We can also have multiple contributor statements. Also code 79, routes to code list 220 as well as 98. As per the routings here - https://onix-codelists.io/codelist/79 - not exhaustive!This is valid Onix XML. We have fixed this in our fork.