Keep specs to unit tests and move lexer scenarios to PHPUnit - #161
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LexerSpechad become an integration test. Most of its examples built real states and regex matchers, so they exercisedAbstractState,RegexFinder,CursorandTokenas well as the lexer. This separates the two kinds of test:tests/Lexer/LexerTest.php, next to the existingNodeTraverserTest. They cover lookahead state switches, zero-length loops, idempotent tokenising, and token and error positions, including from a given start position.LexerSpecnow uses state and token doubles and specifies only the lexer's own behaviour: the state stack, moving the cursor forward, where the cursor starts, detecting zero-length loops, and resetting between calls.SimpleNodeSpec's export example uses node doubles, so it checks only that a node exports its own attributes and children.Value objects such as
TokenPositionandMatchedTextare still used directly in specs.