Fix node child overwrites and string export - #155
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two problems in the node model:
addNode()throwsDuplicateNodeExceptionwhen a child with the same name already exists, instead of silently replacing it. The newreplaceNode()swaps out an existing child in place and throwsNodeNotFoundExceptionif there isn't one.getNode()now throws that exception too, and it's still aRuntimeException.NodeTraverserusesreplaceNode()when a visitor returns a node with the same name. A series of same-type children goes in an array attribute, which the traverser already visits.__toString()exports the whole tree. Before, every child node came out as{}.NodeInterfacenow extendsJsonSerializable, and invalid UTF-8 in attributes is replaced withU+FFFDinstead of causing a TypeError.Breaking changes:
NodeInterfacegainsreplaceNode()andjsonSerialize(), and adding a second child with the same name now throws.