feat(members/excursion): various fixes and LJP proposal enhancements#230
feat(members/excursion): various fixes and LJP proposal enhancements#230
Conversation
…ar ones this includes to the following features: - calculation of org fee should be disabled for older participants in a yl activity - calculation of ljp participants is different for yl acitivitis: there is no age limit. - as a consequence, paid and requested ljp contributions are considerably higher the ljp goal qualification can only occur with the category staff training (also the negation of both). This is restricted by a field validation so the discrimination can check for just one of the fields.
the document - lists all bills for an activity - adds up all allowances on top of the bill overview - adds a custom receipt for the allowances - appends all other receipts in their order on the list
|
📚 Documentation deployed! Documentation: https://chrisflav.github.io/kompass/mk-excursion-fixes/ Docker Images:
Add the |
chrisflav
left a comment
chrisflav
left a comment
There was a problem hiding this comment.
Do I understand correctly that now the finance report is required, but not the actual scanned invoices? Otherwise I am confused why we don't add the invoices to the current LJP finance overview.
chrisflav
changed the title
chrisflav
changed the title
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Co-authored-by: Christian Merten <christian@merten.dev>
Correct, the PDF is currently handed in with the other files. Lately we had several requests to hand in all invoices of an excursion for proper checks. This would be greatly simplified by this feature. Also the internal review of the invoices is simplified if one only has to scroll through a long pdf... |
- add two new variables in settings.toml - replace hardcoded aid values 0.1 and 0.15 by variables
|
If you add a test (or tell me to do it), I'll merge this. |
|
Thanks! |
2 participants
• Full receipt overview for LJP proposals – Added new LaTeX template (ljp_statement.tex) to generate comprehensive invoice and receipt summaries with all supporting documentation
• Download LJP proofs functionality – Implemented download_ljp_proofs() method in admin panel to generate and download complete proof collections with attachments (right next to other lip documents)
• Improved LJP participant counting – Fixed distinction between regular participants and LJP-eligible participants; introduced ljp_participant_count property for accurate subsidies calculation in excursion cost overview
• Qualification activity handling – Activities with qualification goal no longer apply age restrictions to participants and correctly exempt org fees
• Enhanced LJP proposal validation – Added custom form validation to enforce category-goal combinations: Qualification requires Staff Training category; other goals require Educational Programme
• Updated help texts & translations – Added clarifying help texts for night costs, kilometers traveled, and postcode fields; improved German translations throughout
• Org fee logic refinement – Org fees only charged when subsidies or allowances claimed, excluding qualification activities entirely
• UI improvements – Reordered fields in Freizeit admin for better logical flow; updated German translations for LJP-related terminology