allow spaces in include files - #91
Merged
Merged
Conversation
Collaborator
|
Thank you for the PR. Would you be able to add unit tests for this change? |
Collaborator
|
@Sil-Boydens Thanks for your PR! Though I don't want to endorse spaces in include file names ;-) |
Contributor
Author
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an include file like
{"this is an include.i"}
would start a string at the second " and make everything behind it part of that string up to the end of the file. this because the regex for the include files don't allow spaces.
this PR fixes that by allowing spaces in the filenames in include files.
i have been using this version for all of last week and couldn't find any issues with it.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com