Skip to content

fix(player): keep overflow labels out of the control bar - #130

Merged
chrisae9 merged 3 commits into
devfrom
fix/player-language-menu-layout
Oct 21, 2026
Merged

chrisae9 merged 3 commits into
devfrom
fix/player-language-menu-layout

Conversation

@chrisae9

@chrisae9 chrisae9 commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

Audio/subtitle labels appeared as overlapping vertical text in the bottom player bar because overflow-menu grid rules overrode Shaka's hidden control-bar labels. Scope those rules to the overflow menu so its label/value columns remain readable while the bottom bar stays icon-only.

Add a development fixture using the actual Shaka Overlay and SyncLounge audio, subtitle, and Stop controls. It fails with the released CSS and passes with this change. Stop wiring is covered by a DOM click regression; the fixture verifies event delivery, including at 390px.

The apparent live Stop failure was traced to pointer input missing a background Chrome tab. With the intended tab foregrounded, a trusted Stop click changes the player state to stopped, returns to Browse, and removes the video. No redundant production Stop action change is included.

Verification

  • Lint and production build passed.
  • Full test suite: 173 server tests and 647 frontend tests passed.
  • Dependency audit: zero vulnerabilities.
  • Actual Shaka fixture: released CSS fails; corrected CSS passes at desktop and 390px. Stop click dispatches correctly.
  • Live Chrome/Plex Stop check: state stopped, Browse route, no video remaining after a foregrounded trusted click.

Corrected controls

@chrisae9
chrisae9 merged commit 288b5cf into dev Oct 21, 2026
11 checks passed
@chrisae9
chrisae9 deleted the fix/player-language-menu-layout branch October 21, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant