Repository navigation
fix(player): keep overflow labels out of the control bar - #130
Merged
Merged
Conversation
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audio/subtitle labels appeared as overlapping vertical text in the bottom player bar because overflow-menu grid rules overrode Shaka's hidden control-bar labels. Scope those rules to the overflow menu so its label/value columns remain readable while the bottom bar stays icon-only.
Add a development fixture using the actual Shaka Overlay and SyncLounge audio, subtitle, and Stop controls. It fails with the released CSS and passes with this change. Stop wiring is covered by a DOM click regression; the fixture verifies event delivery, including at 390px.
The apparent live Stop failure was traced to pointer input missing a background Chrome tab. With the intended tab foregrounded, a trusted Stop click changes the player state to stopped, returns to Browse, and removes the video. No redundant production Stop action change is included.
Verification