Skip to content

Allow cold model startup and configure embedding timeouts - #1

Merged
chrisae9 merged 2 commits into
mainfrom
fix/embedding-timeout-settings
Sep 16, 2026
Merged

chrisae9 merged 2 commits into
mainfrom
fix/embedding-timeout-settings

Conversation

@chrisae9

@chrisae9 chrisae9 commented Sep 16, 2026 •

Copy link
Copy Markdown
Owner

Local MCP searches could fall back to keyword results while a cold model exceeded the fixed two-second wait, or immediately when another request occupied the worker. Allow 30 seconds for startup and 10 seconds for warm queries, configurable through the embedding JSON. Waiting and inference share one bounded per-call budget; outstanding work remains single-flight and reusable.

Remote embedding queries now default to 10 seconds, background requests to 30 seconds, and client reads to 30 seconds. Remote budgets are independent. Existing TimeoutError fallback metadata is preserved, with safe local reason codes distinguishing startup, query, contention, and stalled-worker limits.

Adds regression coverage for cold/warm budgets, pending-result reuse and failure isolation, bounded admission, and configuration validation. Native qualification now checks both normal cold startup and forced timeout recovery with OS networking denied. Usage documentation explains the settings and their limits. No schema or embedding-identity changes.

Validation: targeted tests, Ruff, actionlint, and diff checks passed. Full CI passed on Linux and macOS with Python 3.11 and 3.14, including offline and recovery checks. Native qualification passed cold startup and forced timeout recovery with OS networking denied. An independent subagent reviewed the implementation; both findings were fixed and regression-tested.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 8c765ea3-20b3-41d5-8aa0-49f84bb28f2c

📥 Commits

Reviewing files that changed from the base of the PR and between a34e43e and 3b18d90.

📒 Files selected for processing (10)
  • .github/workflows/qualification.yml
  • docs/usage.md
  • src/session_search/core/embeddings.py
  • src/session_search/core/local_worker.py
  • src/session_search/interfaces/cli.py
  • src/session_search/interfaces/client.py
  • src/session_search/storage/semantic.py
  • tests/check_local_mcp.py
  • tests/test_local_worker.py
  • tests/test_semantic.py
 ________________________________
< My GPUs mine bugs, not Crypto. >
 --------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/embedding-timeout-settings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chrisae9
chrisae9 merged commit 98b57e8 into main Sep 16, 2026
8 checks passed
@chrisae9
chrisae9 deleted the fix/embedding-timeout-settings branch September 16, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant