Fix/viewport not updating using arrow keyboard#166
Open
ajatdarojat45 wants to merge 3 commits into
Open
Conversation
Contributor
|
Hey @ajatdarojat45, thanks for the changes! @mberz, I tested this just now and releasing the arrow will indeed update the position after a delay of ~1 sec. Did you want it to continuously update, or does this suffice for now? |
Contributor
|
Thanks @ajatdarojat45, I think the non continuous update is absolutely sufficient. I'm wondering though, would it be possible to reduce the delay, or is that something that makes it potentially unstable? |
Contributor
Author
|
Hi @mberz, Yes, it’s possible to reduce the delay. We can lower it to 500 ms, and I think that should still be stable while making the UI feel more responsive. |
Contributor
|
Sounds good. Let's go with 500 ms then. |
Contributor
Author
|
Hi @mberz, I have reduce the delay to 500 ms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @SilvinWillemsen & @mberz,
This PR fixs #165 issue.