Repository navigation
Sudoku: six board themes, readable notes, calm selection (#874) - #876
Merged
Merged
Conversation
A player found Sudoku hard on the eyes: the notes were faint (4.0:1 on the peer shading) and the selected cell was filled with the solid accent (#6A8CBF) with white text at 3.4:1, which hid its notes. - Six board themes behind the gear (Default, Paper, High contrast, Sage, Ocean, Night), each a set of --sd-* custom properties under [data-sd-theme] for the light and the dark app theme (dark twice, system and chosen). Switching sets one attribute; no cell is repainted. - The selected cell is now a theme tint with a 2px ring and keeps its own ink; notes have a darker ink and no background in every theme. - Saved as prefs.boardTheme; an unknown or missing value reads as Default. - tools/tests/sudoku-themes.js checks every colour pair that meets (4.5:1 text, 3:1 lines and ring, ΔE >= 6 between shadings), the names in all seven languages, and the save read-back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QY4t6rHpbsoE5aS15nw6Z7
Contributor
Author
Diff reviewWhy this shape
Tested
Not tested
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #874
A player (under #851) found Sudoku hard on the eyes: faint notes, and a "weird blue" on the selected cell. The blue was the game accent
#6A8CBFfilling the whole selected cell with white digits on it (3.4:1), which also covered that cell's notes (#7C7063, ~2.4:1 on the blue). Notes on the peer shading were 4.0:1.What changed
--sd-*custom properties under[data-sd-theme]: light values once, dark values twice (system and chosen, like breakout/trio). Switching sets one attribute on.sd-wrap; no cell is repainted.--sd-note, weight 700) and have no background.prefs.boardThemein Sudoku's own store, ashighlightis; an unknown or missing value reads as Default. It applies to Classic and Killer.aria-label,aria-pressed) plus the chosen theme's name below them. Names are in all seven languages.Proof
tools/tests/sudoku-themes.js(new, 83 checks). It checks:LOCALE_CODESlanguage;themeOfreads back each saved theme and falls back to the default.exactly six board themes ... (),the selected cell is the theme tint ...,fa: ... missing thLabel ..., ...).node tools/test.js→همهی 9404 بررسی سبز, exit 0.tools/browser-check.sh→All pages loaded without console errors (75 of 75), exit 0.Contact sheet (en, digit selected; top: light app theme, bottom: dark app theme):
Notes cell selected:
Not done / not verified
🤖 Generated with Claude Code
https://claude.ai/code/session_01QY4t6rHpbsoE5aS15nw6Z7