Repository navigation
fix(e2e): tap a control only when it is fully inside the panel - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two-sided E2E suite tapped an options control when only its center was inside the controls panel. On Android, UiAutomator2 reports only the visible part of a clipped element, so a 14 px strip at the panel edge counted as visible; the tap landed and the label assertion then failed because the clipped label was not in the hierarchy (release CI run 43595991628). Now
isControlReadyine2e/helpers/control-navigation.tsaccepts a control only when its whole rectangle is inside the panel margin, and both the Android and the iOS navigators use it.Review focus: a control in the top margin band now scrolls up instead of down.
🤖 Generated with Claude Code