Skip to content

fix(e2e): tap a control only when it is fully inside the panel - #42

Merged
chocky335 merged 1 commit into
mainfrom
fix/e2e-tap-control
Nov 14, 2026
Merged

chocky335 merged 1 commit into
mainfrom
fix/e2e-tap-control

Conversation

@chocky335

Copy link
Copy Markdown
Owner

The two-sided E2E suite tapped an options control when only its center was inside the controls panel. On Android, UiAutomator2 reports only the visible part of a clipped element, so a 14 px strip at the panel edge counted as visible; the tap landed and the label assertion then failed because the clipped label was not in the hierarchy (release CI run 43595991628). Now isControlReady in e2e/helpers/control-navigation.ts accepts a control only when its whole rectangle is inside the panel margin, and both the Android and the iOS navigators use it.

Review focus: a control in the top margin band now scrolls up instead of down.

🤖 Generated with Claude Code

@chocky335
chocky335 merged commit 4f3d709 into main Nov 14, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant