fix(build): pin fmt/spdlog and remove unused websocketpp dependency - #69
Conversation
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe update pins fetched ChangesDependency alignment
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CMakeLists.txt (1)
97-99: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAvoid forcing variables into the global CMake cache.
Using
CACHE BOOL "" FORCEpollutes the global CMake cache and forcefully overrides user-provided configurations (e.g., if a user explicitly configures the project with-DSPDLOG_FMT_EXTERNAL=OFF). In modern CMake (policy CMP0077), setting a normal variable right beforeFetchContent_MakeAvailableproperly scopes the option to the subproject without unexpectedly overwriting the global cache.♻️ Proposed refactor
- set(SPDLOG_FMT_EXTERNAL - ON - CACHE BOOL "" FORCE) + set(SPDLOG_FMT_EXTERNAL ON)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CMakeLists.txt` around lines 97 - 99, Update the SPDLOG_FMT_EXTERNAL configuration near FetchContent_MakeAvailable to use a normal scoped variable instead of CACHE BOOL "" FORCE, preserving the intended ON value for the fetched spdlog subproject without overriding a user-provided cache setting.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CMakeLists.txt`:
- Around line 84-95: Update the find_package calls for fmt and spdlog to require
minimum versions fmt 11.2.0 and spdlog 1.15.3 while retaining QUIET behavior,
ensuring older system installations fall through to the existing pinned
FetchContent declarations.
---
Nitpick comments:
In `@CMakeLists.txt`:
- Around line 97-99: Update the SPDLOG_FMT_EXTERNAL configuration near
FetchContent_MakeAvailable to use a normal scoped variable instead of CACHE BOOL
"" FORCE, preserving the intended ON value for the fetched spdlog subproject
without overriding a user-provided cache setting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b26cff24-7a65-4f1d-96c7-2e1c9283764a
📒 Files selected for processing (6)
.github/workflows/ci.yml.github/workflows/release.ymlCMakeLists.txtDockerfileREADME.mddocs/user_guide/getting_started.md
💤 Files with no reviewable changes (1)
- Dockerfile
## [1.8.1](v1.8.0...v1.8.1) (2026-07-21) ### Bug Fixes * **build:** pin fmt/spdlog and remove unused websocketpp dependency ([#69](#69)) ([a63e131](a63e131))
|
🎉 This PR is included in version 1.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
SPDLOG_FMT_EXTERNAL) instead of its bundled copy; fixes theconstevalcompile errors on the macOS CI runners (fixes CI build fails when compiling fmt/spdlog dependencies on macOS (consteval format string errors) #66)Verification