Persistent home directory, skills seeding/update, and Telegram audit cards by chinkan · Pull Request #40 · chinkan/RustFox

chinkan · 2026-05-29T08:03:54Z

This PR introduces three interconnected features:

1. Persistent home directory model (`~/.rustfox`)

Resolved via RUSTFOX_HOME env → [general].home config → ~/.rustfox
All state lives under the home root: config.toml, rustfox.db, skills/, agents/, workspace/, artifacts/, user_model.md
Path resolution in src/home.rs + Config::resolve() — unset paths default under home, absolute overrides preserved, relative overrides emit legacy warnings

2. Skills/agents seeding and update engine (`src/skills/`)

Bundled skills/ and agents/ directories are seed-copied to the home on first run (seed_dir_if_empty)
/update-skills command re-syncs bundled content using content-hash lock files (skills-lock.json, agents-lock.json)
Locally-modified skills get backed up as *.bak before being overwritten

3. Telegram audit cards (`ToolCallNotifier`)

Persistent structured audit card showing plan checklist and tool activity, never mixed into the answer stream
Privacy-aware format_args_preview using allowlist/denylist model to avoid leaking secrets
Plan plan_create/plan_update parsed into a visual checklist with step status markers
Terminal Finished event persists a completed/failed summary card (or deletes if no activity)
Edit retry logic for rate-limit resilience

Additional changes

Comprehensive design spec and implementation plan documents
Regression tests for message flow, argument redaction, plan rendering, skill seeding/update
Integration test for sandbox-home isolation

github-actions · 2026-05-29T08:04:09Z

Claude encountered an error after 0s —— View job

I'll analyze this and get back to you.

Copilot

Pull request overview

This PR refactors Telegram verbose-mode progress reporting into a single persistent "audit card" managed by ToolCallNotifier, and removes the duplicate path that previously streamed tool-status lines into the assistant answer. It also adds a privacy-aware argument preview formatter and a structured plan/tool display model.

Changes:

Adds a ToolDisplayState with plan checklist + tool activity rendering, parses plan_create/plan_update arguments, and tightens format_args_preview to an allowlist/denylist model.
Introduces ToolEvent::Finished and reworks ToolCallNotifier::finish to edit the live message into a persistent completed/failed card (or delete it when no activity occurred).
Removes the agent-side stream_status_tx path so tool status lines no longer enter the answer stream, and adds a source-inspection regression test.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/platform/tool_notifier.rs	Adds display state, planning parsers, privacy-aware preview, persistent finish card, edit retry, and new tests.
src/platform/telegram.rs	Forwards a terminal `Finished` event to the notifier and finalizes the notifier even if the channel closes unexpectedly.
src/agent.rs	Removes duplicate tool-status streaming; sends raw `arguments_json` to the notifier; adds source-inspection regression test.
docs/superpowers/specs/2026-05-28-telegram-plan-tool-visuals-design.md	New design spec for verbose-mode audit card.
docs/superpowers/plans/2026-05-28-telegram-plan-tool-visuals.md	New implementation plan with step-by-step tasks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…olved_home

…e TOML table

github-actions · 2026-06-01T00:42:57Z

Claude encountered an error after 1s —— View job

I'll analyze this and get back to you.

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 7 comments.

+        if !lock_path.exists() {
+            let lock = rustfox::skills::update::SkillLock {
+                version: 1,
+                skills: rustfox::skills::seed::lock_map_for(&config.skills.directory),
+            };


+            .config
+            .resolved_home
+            .clone()
+            .map(|h| h.join("skills-lock.json"))
+            .unwrap_or_else(|| std::path::PathBuf::from("skills-lock.json"));


+impl UpdateReport {
+    pub fn summary(&self) -> String {
+        format!(
+            "Skill update: {} updated, {} backed-up, {} unchanged.",


+        anyhow::bail!("No bundled skills found at {}", bundled.display());
+    }
+    let mut lock = read_lock(lock_path);
+    tokio::fs::create_dir_all(instance).await.ok();


            }
-        }
-        s
+            text


+    /// Resolve the home root and every data path, create directories, and write
+    /// the resolved absolute paths back into the config fields. Returns any
+    /// legacy-path warnings (relative overrides) for the caller to log.


+> **Persistent home:** RustFox keeps all state under `~/.rustfox` by default
+> (config, database, skills, agents, and a durable `workspace/` sandbox).
+> Override with the `RUSTFOX_HOME` environment variable or `[general].home`.
+> See [docs/persistent-home-directory.md](docs/persistent-home-directory.md).


…nd bundled layers - Introduced `SkillSource` enum to differentiate between instance and bundled skills. - Refactored `SkillRegistry` to maintain separate maps for instance and bundled skills, along with a mapping for base directories. - Updated `load_skills_from_dir` to accept a `SkillSource` parameter and adjusted all relevant calls. - Added `bundled_directory` configuration fields to `SkillsConfig` and `AgentsConfig`. - Enhanced agent tools to resolve skill and agent file paths using the new registry structure. - Modified startup logic to load both instance and bundled skills, merging them appropriately. - Updated tests to cover new functionality and ensure correct behavior of skill loading and resolution.

github-actions · 2026-06-01T09:46:06Z

Claude encountered an error after 0s —— View job

I'll analyze this and get back to you.

…nd specification checks

github-actions · 2026-06-02T02:26:39Z

Claude encountered an error after 1s —— View job

I'll analyze this and get back to you.

Copilot

Pull request overview

Copilot reviewed 34 out of 35 changed files in this pull request and generated 4 comments.

+        {
+            let mut skills = self.skills.write().await;
+            if let Ok(reg) = s_instance {
+                skills.instance_skills = reg.instance_skills;
+                for (k, v) in &reg.skill_base_dirs {
+                    skills.skill_base_dirs.insert(k.clone(), v.clone());
+                }
+            }
+            if let Ok(reg) = s_bundled {
+                skills.bundled_skills = reg.bundled_skills;
+                for (k, v) in &reg.skill_base_dirs {
+                    skills
+                        .skill_base_dirs
+                        .entry(k.clone())
+                        .or_insert_with(|| v.clone());
+                }
+            }
+        }


+        if instance_hash.as_deref() == Some(bundled_hash.as_str()) {
+            report.skipped.push(name);
+            continue;
+        }


+pub fn hash_skill_dir(dir: &Path) -> Option<String> {
+    let primary = ["SKILL.md", "AGENT.md"]
+        .into_iter()
+        .map(|f| dir.join(f))
+        .find(|p| p.is_file())?;
+    let bytes = std::fs::read(&primary).ok()?;
+    let mut h = Sha256::new();
+    h.update(&bytes);
+    Some(format!("{:x}", h.finalize()))
+}


    }
-    // Fallback: truncate raw JSON
-    crate::utils::strings::truncate_chars(args_json, 60)
+    let joined = parts.join(", ");
+    crate::utils::strings::truncate_chars(&joined, MAX_DISPLAY_FIELD_CHARS)


github-actions · 2026-06-02T09:30:55Z

Claude encountered an error after 0s —— View job

I'll analyze this and get back to you.

Copilot

Pull request overview

Copilot reviewed 34 out of 35 changed files in this pull request and generated 3 comments.

Copilot · 2026-06-02T09:45:46Z

+        if !unmodified {
+            // Back up the primary file to a sibling path OUTSIDE the dir being replaced.
+            for f in ["SKILL.md", "AGENT.md"] {
+                let p = dst.join(f);
+                if p.is_file() {
+                    let bak = instance.join(format!("{name}.{f}.bak.tmp"));
+                    let _ = tokio::fs::copy(&p, &bak).await;
+                }
+            }
+            let _ = tokio::fs::remove_dir_all(&dst).await;
+            copy_dir_recursive_pub(&src, &dst).await?;
+            // Move the temp backups into the freshly-copied dir as <file>.bak
+            for f in ["SKILL.md", "AGENT.md"] {
+                let bak = instance.join(format!("{name}.{f}.bak.tmp"));
+                if bak.is_file() {
+                    let _ = tokio::fs::rename(&bak, dst.join(format!("{f}.bak"))).await;
+                }
+            }


Fixed in the latest commit. The backup logic now renames the entire instance directory to <name>.bak (removing a stale .bak dir first if one exists) instead of selectively copying only SKILL.md/AGENT.md. This preserves all user files. The docstring and test have been updated to match.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-06-02T09:39:15Z

Claude encountered an error after 0s —— View job

I'll analyze this and get back to you.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-06-02T09:39:43Z

Claude encountered an error after 0s —— View job

I'll analyze this and get back to you.

…f only SKILL.md/AGENT.md

github-actions · 2026-06-03T06:35:05Z

Claude encountered an error after 1s —— View job

I'll analyze this and get back to you.

feat: add telegram plan tool audit cards

8bca36a

Copilot AI review requested due to automatic review settings May 29, 2026 08:03

Copilot started reviewing on behalf of chinkan May 29, 2026 08:04 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

chinkan added 24 commits May 29, 2026 17:01

docs: design persistent home directory (~/.rustfox)

dd381b3

docs: add persistent home directory implementation plan

671b7ce

docs: fix cp nesting in migration hint (use cp -rT)

677c98d

build: add dirs crate for home directory resolution

2868cfd

feat(home): add resolve_home with env/config/default precedence

e7018ff

feat(home): add resolve_data_path with origin classification

ca792ee

feat(home): add ResolvedPaths and ensure_dirs (0700)

e5014d7

feat(home): add LegacyPathWarning with actionable render()

8cb7e80

style(home): cargo fmt fixups

e147c45

refactor(config): make data paths optional + add general.home and res…

65802da

…olved_home

feat(config): add Config::resolve to materialize home-relative paths

cdf31e5

feat(config): resolve paths and log legacy warnings in load

547d640

feat(home): config-file discovery fallback to <home>/config.toml

03e713f

test+docs: assert sandbox=workspace and note persistence in prompt

041c5b2

feat(skills): add content hashing + first-run seed copy

ea8ce2d

feat(skills): add /update-skills hash-diff engine with backups

c291b77

feat(skills): add tracing to update_skills for observability

ecbc222

feat: seed bundled skills/agents into home on first run

a2fd092

feat(agent): add reload_skills_and_agents helper

c2f0549

feat(telegram): add /update-skills command and help entry

51ed26c

docs: document ~/.rustfox home and optional paths in example config

d5e99a9

docs: add persistent home directory migration tutorial

0f6cc2f

docs: document persistent home directory in CLAUDE.md and README

f342674

docs: place [general].home hint in existing section to avoid duplicat…

e7a68ef

…e TOML table

Copilot started reviewing on behalf of chinkan June 1, 2026 08:19 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

chinkan changed the title ~~Add audit cards for Telegram plan tool~~ Persistent home directory, skills seeding/update, and Telegram audit cards Jun 1, 2026

chinkan added 2 commits June 1, 2026 17:43

feat: add codebase gap analysis skill and enhance lock file handling

0a08872

feat: add various reviewers and implementer agents for code quality a…

d21d743

…nd specification checks

chinkan requested a review from Copilot June 2, 2026 02:30

Copilot started reviewing on behalf of chinkan June 2, 2026 02:30 View session

Copilot AI reviewed Jun 2, 2026

View reviewed changes

Copilot started work on behalf of chinkan June 2, 2026 02:33 View session

Copilot AI added 2 commits June 2, 2026 02:41

Fix PR review regressions in reload, lock seeding, and previews

9a04288

Add lock-preservation regression and finalize preview formatting

868f828

Copilot finished work on behalf of chinkan June 2, 2026 02:45

docs: sync README with codebase, bump default model to kimi-k2.6

b6c9464

chinkan requested a review from Copilot June 2, 2026 09:34

Copilot started reviewing on behalf of chinkan June 2, 2026 09:34 View session

Copilot AI reviewed Jun 2, 2026

View reviewed changes

Potential fix for pull request finding

d8d3448

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

abc4576

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot started work on behalf of chinkan June 2, 2026 09:41 View session

fix(update): rename entire instance dir to <name>.bak instead o…

4cfa4cd

…f only SKILL.md/AGENT.md

Copilot finished work on behalf of chinkan June 2, 2026 09:46

fmt: cargo fmt fix for with_context closure formatting

3502003

ci: remove Claude Code Review workflow

544f564

Uh oh!

Conversation

chinkan commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1. Persistent home directory model (~/.rustfox)

2. Skills/agents seeding and update engine (src/skills/)

3. Telegram audit cards (ToolCallNotifier)

Additional changes

Uh oh!

github-actions Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chinkan commented May 29, 2026 •

edited

Loading

1. Persistent home directory model (`~/.rustfox`)

2. Skills/agents seeding and update engine (`src/skills/`)

3. Telegram audit cards (`ToolCallNotifier`)

github-actions Bot commented May 29, 2026 •

edited

Loading

github-actions Bot commented Jun 1, 2026 •

edited

Loading

github-actions Bot commented Jun 1, 2026 •

edited

Loading

github-actions Bot commented Jun 2, 2026 •

edited

Loading

github-actions Bot commented Jun 2, 2026 •

edited

Loading

github-actions Bot commented Jun 2, 2026 •

edited

Loading

github-actions Bot commented Jun 2, 2026 •

edited

Loading

github-actions Bot commented Jun 3, 2026 •

edited

Loading