fix(useScriptTag): convert Event to Error in promise rejection#184
Merged
childrentime merged 2 commits intomainfrom Jan 4, 2026
Merged
fix(useScriptTag): convert Event to Error in promise rejection#184childrentime merged 2 commits intomainfrom
childrentime merged 2 commits intomainfrom
Conversation
Certain sites reject errors with an Event object, not an Error. This causes issues with global uncaught exception handlers that expect Error objects, resulting in confusing error messages like 'Event Event (type=error) captured as promise rejection'. This fix converts Event objects to proper Error objects before rejecting the promise, while preserving the original event for debugging purposes via error.event property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Certain sites reject errors with an Event object, not an Error. This causes issues with global uncaught exception handlers that expect Error objects, resulting in confusing error messages like "Event Event (type=error) captured as promise rejection" when a script load is interrupted.
Solution
error.eventpropertyScriptLoadErrorandScriptLoadAbortError)Changes
errorandabortevent handlers inuseScriptTagto create Error objectsTesting
error.event)