Expose user to do forms data to integrations#612
Open
andreas-ntonas wants to merge 1 commit into
Open
Conversation
GDay
reviewed
Jan 21, 2026
GDay
left a comment
GDay
left a comment
Member
There was a problem hiding this comment.
Thank you! I like this change, but see the comment below. I am open to other ideas too.
Comment on lines
+583
to
+585
| while todo_slug in todo_forms: | ||
| todo_slug = f"{original_slug}_{counter}" | ||
| counter += 1 |
Member
There was a problem hiding this comment.
I do get the intention of this, but I am not sure if this will work well when a to do item gets updated. It's now a list and when someone adds a new item in the middle, then the order gets completely messed up. When using this in integrations, that could have some major consequences.
This might go beyond the scope of this PR, but I feel like we should set an identifier through the frontend (that would likely require changes to the editor-form.js, so we are sure we send the correct value and any updates to the to do item would not cause issues.
andreas-ntonas
force-pushed
the
Expose-user-to-do-forms-data-to-integrations
branch
from
696f9e8 to
f7371bb
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the exposure of to-do related form data filled by new-hires to integrations