fix(core): preserve cached worker view buffers - #43
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-fix reproduction
bun test packages/core/test/worker-renderer.test.tsproduced 7 pass / 1 fail. The second paint threwDataCloneError: The object can not be clonedwhen the faithful fake Worker attempted to transfer the already-detached cached view buffers.Verification
bun test packages/core/test/worker-renderer.test.ts— 10 passbun test packages/core/test— 756 passbun run typecheck— passbun run api:check— passbun run lint— pass (existing corpus-size warning only)bun scripts/check-import-cycles.ts— passbun run changeset:ci— passbun test— 1270 pass / the same 7 known unrelated failures (compatibility inventory + six billion-cell gate checks)Local WebKit could not launch because host dependencies require interactive sudo; Required CI supplies those dependencies and remains the browser gate.