fix(ci): gate every pull request against its base - #39
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI currently runs only for pull requests targeting
develop. A feature PR targeting a release branch therefore receives no checks. The Changesets gate also always compares withorigin/develop, so a PR into another base can inherit changesets from earlier branch work.Change
developGITHUB_BASE_REFonce, with anorigin/developfallback outside PR context--sinceargumenttest:toolingThis intentionally avoids hardcoding
0.4.0; future release branches inherit correct CI and comparison behavior without another workflow edit.release.ymlandversion.ymlremain develop-only.Verification
bun test scripts/changeset-ci.test.ts scripts/workflow-contract.test.ts— 13 pass, 0 failbun run test:tooling— 140 pass, 0 failbun run typecheck— passed for all workspaces and verification consumersbun run lint— passed with the existing 2 MiB corpus size warning onlyGITHUB_BASE_REF=develop bun run changeset:ci— passed; empty tooling changeset, no package bumpfetch-depth: 0, soorigin/<base>is available without a job change