chore(ci): install only Chromium for benchmark smoke - #38
Merged
Conversation
The unit-coverage job launches Chromium through bench:verify but installed Firefox and WebKit plus their system dependencies on every run. Use the existing Chromium-only installer there; the dedicated browser-smoke job continues to install and exercise all three engines. Contract the command rather than the step label so harmless presentation renames do not break the test.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
unit-coverageinstalled Chromium, Firefox, WebKit, and all three engines' system dependencies on every run throughbrowser:install. None of that job's consumers launches Firefox or WebKit.bench:verifyshells out torender-driver.ts --smoke;render-driver.tsimports and launches onlychromium. The other browser-adjacent unit target,test/browser/canvas-assertions.test.ts, does not launch Playwright. The dedicatedbrowser-smokejob remains unchanged and continues installing/running the full Chromium + Firefox + WebKit matrix.Change
Use the existing
browser:install:chromiumscript inunit-coverage. Add a workflow contract that asserts the unit job contains the Chromium-only command and does not contain the bare full-browser command. It tests behavior, not the step's display name.Verification
bun test scripts/workflow-contract.test.ts— 7 pass, 0 failbun run test:tooling— 134 pass, 0 failbun run typecheck— all workspace nodes exit 0bun run lint— no errors; one pre-existing 2 MiB corpus warningbun run --filter '@sheetwrite/bench' bench:verify— smoke and safety checks passedbun run changeset:ci— passed; empty changeset, no package bumpNo browser test matrix, runtime source, package script, or release behavior changes.