Skip to content

機能しないチャンネル外リノート許可設定を廃止し常に許可に変更 - #29

Merged
kozakura913 merged 1 commit into
cheripia-dev:developfrom
kozakura913:fix/remove-allow-renote-to-external
Nov 7, 2026
Merged

機能しないチャンネル外リノート許可設定を廃止し常に許可に変更#29
kozakura913 merged 1 commit into
cheripia-dev:developfrom
kozakura913:fix/remove-allow-renote-to-external

Conversation

@kozakura913

@kozakura913 kozakura913 commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

What

連合が allowRenoteToExternal をサポートしないため、設定項目を削除しチャンネル外リノートを常に許可とする。

Why

Close: #21

Additional info (optional)

  • backend: MiChannel のカラム・NoteCreateService/NoteDraftService の 拒否検証・channels create/update のパラメータ・json-schema・ pack 出力・関連 API エラー定義を削除
  • migration: channel.allowRenoteToExternal を DROP する新規 migration (down で DEFAULT true により再追加)
  • frontend: チャンネル編集画面からスイッチを削除し、リノート/引用 メニュー・リノートボタンの許可ゲートを除去
  • locales: ja-JP.yml の該当キー削除、i18n / misskey-js autogen 再生成
  • tests: チャンネル外リノート (TL・別チャンネル・ドラフト) が常に 成功する e2e ケースを追加

Checklist

  • コントリビューションガイドを読みました( Read the contribution guide)
  • ローカル環境で動作しました(Test working in a local environment)
  • (必要なら)CHANGELOG_CHERIPIA.mdの更新((If needed) Update CHANGELOG_CHERIPIA.md)
  • (必要なら)テストの追加((If possible) Add tests)

@kozakura913
fix: 機能しないチャンネル外リノート許可設定を廃止し常に許可に変更
34792e6 
連合が allowRenoteToExternal をサポートしないため、設定項目を削除し
チャンネル外リノートを常に許可とする。

- backend: MiChannel のカラム・NoteCreateService/NoteDraftService の
  拒否検証・channels create/update のパラメータ・json-schema・
  pack 出力・関連 API エラー定義を削除
- migration: channel.allowRenoteToExternal を DROP する新規 migration
  (down で DEFAULT true により再追加)
- frontend: チャンネル編集画面からスイッチを削除し、リノート/引用
  メニュー・リノートボタンの許可ゲートを除去
- locales: ja-JP.yml の該当キー削除、i18n / misskey-js autogen 再生成
- tests: チャンネル外リノート (TL・別チャンネル・ドラフト) が常に
  成功する e2e ケースを追加

Refs cheripia-dev#21
@kozakura913
kozakura913 requested a review from 4ster1sk November 7, 2026 06:45
@kozakura913 kozakura913 self-assigned this Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

このPRによるapi.jsonの差分

差分はこちら 
--- base
+++ head
@@ -28869,12 +28869,6 @@
                       "null"
                     ]
                   },
-                  "allowRenoteToExternal": {
-                    "type": [
-                      "boolean",
-                      "null"
-                    ]
-                  },
                   "username": {
                     "type": "string"
                   }
@@ -31394,12 +31388,6 @@
                       "boolean",
                       "null"
                     ]
-                  },
-                  "allowRenoteToExternal": {
-                    "type": [
-                      "boolean",
-                      "null"
-                    ]
                   }
                 },
                 "required": [
@@ -74815,15 +74803,6 @@
                       }
                     }
                   },
-                  "CANNOT_RENOTE_OUTSIDE_OF_CHANNEL": {
-                    "value": {
-                      "error": {
-                        "message": "Cannot renote outside of channel.",
-                        "code": "CANNOT_RENOTE_OUTSIDE_OF_CHANNEL",
-                        "id": "33510210-8452-094c-6227-4a6c05d99f00"
-                      }
-                    }
-                  },
                   "CONTAINS_PROHIBITED_WORDS": {
                     "value": {
                       "error": {
@@ -75666,15 +75645,6 @@
                       }
                     }
                   },
-                  "CANNOT_RENOTE_OUTSIDE_OF_CHANNEL": {
-                    "value": {
-                      "error": {
-                        "message": "Cannot renote outside of channel.",
-                        "code": "CANNOT_RENOTE_OUTSIDE_OF_CHANNEL",
-                        "id": "33510210-8452-094c-6227-4a6c05d99f00"
-                      }
-                    }
-                  },
                   "CONTAINS_PROHIBITED_WORDS": {
                     "value": {
                       "error": {
@@ -75711,15 +75681,6 @@
                       }
                     }
                   },
-                  "CANNOT_RENOTE_TO_EXTERNAL": {
-                    "value": {
-                      "error": {
-                        "message": "Cannot Renote to External.",
-                        "code": "CANNOT_RENOTE_TO_EXTERNAL",
-                        "id": "ed1952ac-2d26-4957-8b30-2deda76bedf7"
-                      }
-                    }
-                  },
                   "SCHEDULED_AT_REQUIRED": {
                     "value": {
                       "error": {
@@ -76562,15 +76523,6 @@
                       }
                     }
                   },
-                  "CANNOT_RENOTE_OUTSIDE_OF_CHANNEL": {
-                    "value": {
-                      "error": {
-                        "message": "Cannot renote outside of channel.",
-                        "code": "CANNOT_RENOTE_OUTSIDE_OF_CHANNEL",
-                        "id": "33510210-8452-094c-6227-4a6c05d99f00"
-                      }
-                    }
-                  },
                   "CONTAINS_PROHIBITED_WORDS": {
                     "value": {
                       "error": {
@@ -76625,15 +76577,6 @@
                       }
                     }
                   },
-                  "CANNOT_RENOTE_TO_EXTERNAL": {
-                    "value": {
-                      "error": {
-                        "message": "Cannot Renote to External.",
-                        "code": "CANNOT_RENOTE_TO_EXTERNAL",
-                        "id": "ed1952ac-2d26-4957-8b30-2deda76bedf7"
-                      }
-                    }
-                  },
                   "NO_SUCH_REPLY": {
                     "value": {
                       "error": {
@@ -102447,9 +102390,6 @@
               "isSensitive": {
                 "type": "boolean"
               },
-              "allowRenoteToExternal": {
-                "type": "boolean"
-              },
               "userId": {
                 "type": [
                   "string",
@@ -102462,7 +102402,6 @@
               "name",
               "color",
               "isSensitive",
-              "allowRenoteToExternal",
               "userId"
             ]
           },
@@ -102736,9 +102675,6 @@
               "isSensitive": {
                 "type": "boolean"
               },
-              "allowRenoteToExternal": {
-                "type": "boolean"
-              },
               "userId": {
                 "type": [
                   "string",
@@ -102751,7 +102687,6 @@
               "name",
               "color",
               "isSensitive",
-              "allowRenoteToExternal",
               "userId"
             ]
           },
@@ -104445,9 +104380,6 @@
           "isSensitive": {
             "type": "boolean"
           },
-          "allowRenoteToExternal": {
-            "type": "boolean"
-          },
           "isFollowing": {
             "type": "boolean"
           },
@@ -104489,7 +104421,6 @@
           "usersCount",
           "notesCount",
           "isSensitive",
-          "allowRenoteToExternal",
           "host"
         ]
       },
[Get diff files from Workflow Page](https://github.com/cheripia-dev/cheripia/actions/runs/42348537362)

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

🖥 Frontend Diagnostics Report

(No significant changes)

View details

Requests by resource type
Type Requests Encoded bytes
Base Head Δ Base Head Δ
Document 2 2 0 39 KB 39 KB 0 B
Script 155 155 0 3.3 MB 3.3 MB $\color{green}{\text{-883 B}}$
Stylesheet 68 68 0 338 KB 338 KB $\color{green}{\text{-1 B}}$
Fetch 22 22 0 55 KB 55 KB 0 B
Image 10 10 0 386 KB 386 KB 0 B
Font 6 6 0 8.4 MB 8.4 MB $\color{green}{\text{-149 B}}$
Other 9 9 0 354 KB 354 KB $\color{green}{\text{-14 B}}$
V8 heap snapshot statistics
Metric @ Base @ Head Δ MAD
$\color{gray}{\rule{8pt}{8pt}}$ Total 19 MB
± 16 KB		 19 MB
± 15 KB		 $\text{-4.2 KB}$
$\text{-0\%}$ 		22 KB
$\color{orange}{\rule{8pt}{8pt}}$ Code 3.6 MB 3.6 MB $\text{+6.5 KB}$ 1.7 KB
$\color{red}{\rule{8pt}{8pt}}$ Strings 2.4 MB 2.4 MB $\text{-200 B}$ 462 B
$\color{cyan}{\rule{8pt}{8pt}}$ JS arrays 156 KB 156 KB $\text{-36 B}$ 56 B
$\color{green}{\rule{8pt}{8pt}}$ Typed arrays 0 B 0 B 0 B 0 B
$\color{yellow}{\rule{8pt}{8pt}}$ System objects 0 B 0 B 0 B 0 B
$\color{violet}{\rule{8pt}{8pt}}$ Other JS objs 4.9 MB 4.9 MB $\text{+968 B}$ 64 B
$\color{pink}{\rule{8pt}{8pt}}$ Other non-JS objs 7.5 MB 7.5 MB $\text{-804 B}$ 17 KB

Download representative heap snapshot: base / head

📦 Bundle Stats

Chunk size diff (2 updated, 0 added, 0 removed)
Chunk Base Head Δ Δ (%)
(total) 7.5 MB 7.5 MB $\text{-856 B}$ $\text{-0\%}$
src/pages/channel-editor.vue ja-JP/DXocxs4KS-BzxLinFl.js → ja-JP/lHEnq0LW0-DUJIrSNr.js
9.1 KB 8.9 KB $\text{-262 B}$ $\color{green}{\text{-2.9\%}}$
i18n ja-JP/DXocxs4KS-CkhPrqcb.js → ja-JP/lHEnq0LW0-C0s7lP7h.js
266 KB 266 KB $\text{-103 B}$ $\text{-0\%}$
(other generated chunks) 2.4 MB 2.4 MB $\text{-491 B}$ $\text{-0\%}$
Startup chunk size (1 updated, 0 added, 0 removed)
Chunk Base Head Δ Δ (%)
(total) 1.5 MB 1.4 MB $\text{-543 B}$ $\text{-0\%}$
i18n ja-JP/DXocxs4KS-CkhPrqcb.js → ja-JP/lHEnq0LW0-C0s7lP7h.js
266 KB 266 KB $\text{-103 B}$ $\text{-0\%}$
(other generated chunks) 902 KB 902 KB $\text{-440 B}$ $\text{-0\%}$
(other) 282 KB 282 KB 0 B 0%

Startup chunks are the Vite entry for src/_boot_.ts and its static imports.

Bundles Modules Entries Imports Size
Static Dynamic Rendered Gzip Brotli
Base 525 3,743 23 15,135 395 13 MB 3.6 MB 3.1 MB
Head 525 3,743 23 15,135 395 13 MB 3.6 MB 3.1 MB
Δ 0 0 0 0 0 $\color{green}{\text{-1.5 KB}}$ $\text{-191 B}$ $\text{-148 B}$
Δ (%) 0% 0% 0% 0% 0% $\text{-0\%}$ $\text{-0\%}$ $\text{-0\%}$

Open treemap HTML

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

⚙️ Backend Diagnostics Report

Memory: After GC

(No significant changes)

V8 Heap Snapshot Statistics

Metric @ Base @ Head Δ MAD
$\color{gray}{\rule{8pt}{8pt}}$ Total 105 MB
± 2.7 KB		 105 MB
± 1.1 KB		 $\text{-11 KB}$
$\text{-0\%}$ 		2.9 KB
$\color{orange}{\rule{8pt}{8pt}}$ Code 29 MB 29 MB $\text{-5.6 KB}$ 4.3 KB
$\color{red}{\rule{8pt}{8pt}}$ Strings 40 MB 40 MB $\text{-5.4 KB}$ 799 B
$\color{cyan}{\rule{8pt}{8pt}}$ JS arrays 5.9 MB 5.9 MB $\text{-8 B}$ 0 B
$\color{green}{\rule{8pt}{8pt}}$ Typed arrays 610 KB 610 KB 0 B 0 B
$\color{yellow}{\rule{8pt}{8pt}}$ System objects 2.3 MB 2.3 MB $\text{+192 B}$ 585 B
$\color{violet}{\rule{8pt}{8pt}}$ Other JS objs 27 MB 27 MB $\text{-1.9 KB}$ 104 B
$\color{pink}{\rule{8pt}{8pt}}$ Other non-JS objs 40 KB 40 KB 0 B 0 B

Download representative heap snapshot: base / head

@kozakura913
kozakura913 merged commit 97dc57d into cheripia-dev:develop Nov 7, 2026
48 of 49 checks passed
@kozakura913 kozakura913 added this to the 1.14.0 milestone Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@4ster1sk 4ster1sk 4ster1sk approved these changes

Assignees

@kozakura913 kozakura913

Labels

packages/backend:test packages/backend packages/frontend packages/misskey-js

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

機能しないチャンネル外リノート許可設定が残っている

2 participants

@kozakura913 @4ster1sk