Update to Kotlin 1.0.0-beta-3595#13
Open
phroa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm super unfamiliar with this library. This PR probably needs a load of review; I just wanted it to compile on the latest version so I can use it in a project, which it does.
I tried to go through and fix the build warnings that I felt comfortable fixing, but I don't know exactly what the state of the warnings were beforehand since it wouldn't compile. By no means did I remove them all, though :)
Tests fail, but given the fact that it can't find
assertEqualsleads me to believe that they weren't always working. I didn't even try to fix them. Here's the output ofgradle assemble test. https://gist.github.com/phroa/31c18af5c25c2f29a47aComments appreciated.