Skip to content

feat: 增加黑名单功能 & 优化 WIFI 连接 - #60

Merged
chenxuuu merged 2 commits into
chenxuuu:masterfrom
Tsuk1ko:feat/blacklist
Mar 22, 2026
Merged

chenxuuu merged 2 commits into
chenxuuu:masterfrom
Tsuk1ko:feat/blacklist

Conversation

@Tsuk1ko

@Tsuk1ko Tsuk1ko commented Mar 22, 2026

Copy link
Copy Markdown
Contributor
  1. 增加黑名单功能,位于黑名单内的短信不转发,可以用于过滤运营商推广短信、公益短信等无用短信,该功能我已自用一个多月
  2. WIFI 连接模式设置为扫描所有信道,原本默认逻辑为连接第一个扫描到的,这可能导致 mesh 等多 AP 情况下连接到信号弱的 AP,这个问题我也是最近才发现,导致有时候开发板断联

不太熟悉C++所以代码是AI生成,辛苦 review

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求主要增强了系统的短信处理能力和网络连接稳定性。通过引入可配置的号码黑名单,用户可以更好地控制短信转发,避免接收不必要的通知。同时,对 WIFI 连接机制的改进解决了在复杂网络环境中设备可能连接到弱信号接入点的问题,显著提升了设备的可靠性和用户体验。

Highlights

  • 短信黑名单功能: 引入了短信黑名单功能,允许用户配置不希望转发的号码,有效过滤运营商推广短信和公益短信等。
  • WIFI 连接优化: 优化了 WIFI 连接逻辑,将扫描方式设置为扫描所有信道,以确保在多 AP 环境下连接到信号最强的接入点,避免连接到弱信号 AP 导致设备断联。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

你好,感谢你的贡献!这次的 PR 增加了黑名单功能并优化了 WIFI 连接,功能上很有用。

  1. 黑名单功能:代码在配置、UI 和短信处理逻辑中都做了相应修改,整体实现是正确的。我在 isInNumberBlackList 函数中发现了一个可以优化内存使用的地方,已经提出了具体的修改建议。在嵌入式开发中,对内存使用的优化尤其重要。
  2. WIFI 连接优化:通过设置 WIFI_ALL_CHANNEL_SCAN 来扫描所有信道,可以有效解决在 mesh 网络中可能连接到信号较弱 AP 的问题。这个改动很棒。

代码风格与项目现有代码保持一致。除了我提出的那个小建议,其他部分看起来都不错。辛苦了!

Comment thread code/code.ino Outdated
@chenxuuu
chenxuuu merged commit 9b82817 into chenxuuu:master Mar 22, 2026
1 check passed
@Tsuk1ko
Tsuk1ko deleted the feat/blacklist branch March 22, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants