Open
Conversation
7f0b67e to
42ddab1
Compare
Signed-off-by: sandhi <sagarwal@progress.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the CI workflow and Grype scan workflows to improve flexibility, security, and reliability for PR checks and image scanning. The main changes include adding new input parameters for event and branch context, improving token handling for GitHub authentication, refactoring the BlackDuck Polaris SAST scan job to use a reusable workflow, and enhancing Grype scan logic to avoid AWS ECR rate limits and deduplicate vulnerability reporting.
Workflow Inputs and Context Passing
github-event-nameandgithub-branch-nameto.github/workflows/ci-main-pull-request.ymland propagated these to relevant jobs, enabling workflows to receive GitHub event and branch context for more accurate PR comment detection and branch-specific logic. [1] [2] [3] [4] [5]grype-image-skip-awsinput to both.github/workflows/ci-main-pull-request.ymland.github/workflows/grype.ymlto allow skipping Grype scans on AWS ECR images, preventing rate limit issues when images are already scanned by other tools. [1] [2] [3] [4] [5]Security and Token Handling
GITHUB_TOKENto preferGH_TOKENif available, improving support for custom tokens and private repository access in CI jobs and git configuration. [1] [2] [3]BlackDuck Polaris SAST Scan Refactor
.github/workflows/ci-main-pull-request.ymlto use the reusable workflowchef/common-github-actions/.github/workflows/polaris-sast.yml@main, consolidating configuration and simplifying maintenance. All relevant inputs are now passed directly to the reusable workflow.Grype Scan Improvements
.github/workflows/grype.ymlto deduplicate vulnerabilities by CVE, package, and version, providing more accurate counts for critical and high severity findings.These changes improve the maintainability, reliability, and accuracy of CI and security workflows, especially for complex PR and image scanning scenarios.
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.