bugfix: candidate_id should be a string#76
Open
xiaoronglv wants to merge 3 commits intocheckr:masterfrom
Open
Conversation
Problem: when retrieving the report, the candidate is a json object. alias method can't delegate `candidate_id` to the candidate object. What's the change? explicitly define the method to access the candidate_id
xiaoronglv
commented
Aug 1, 2022
| attribute :turnaround_time | ||
| attribute :package | ||
| attribute :values | ||
| attribute :candidate_id |
Contributor
Author
There was a problem hiding this comment.
this is the key line.
Contributor
Author
|
Hi @akshay-8d66 , could you please help to review my code when you get the time? |
Contributor
|
This makes sense to me. Could you look into the failing tests. Happy to help if it's unclear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Based on the documentation, the candidate_id attribute of the report model should be a string. This gem using alias method to delegate
candidate_idto the candidate object, which is a json object.it caused errors.
Changes
explicitly define the method to access the candidate_id
reference
https://docs.checkr.com/#operation/getReport