Repository navigation
feat(payments): add fallback_source to the payment request - #691
Merged
Merged
Conversation
POST /payments accepts fallback_source, an alternative card source to attempt when the primary source fails. PaymentRequest now exposes it as fallbackSource, typed as RequestCardSource. RequestCardSource gains allowUpdate, which the spec defines on both the primary card source and the fallback source, and its doc comments are rewritten from the spec. PaymentRequest documents the amount range and the deprecated payment_ip and marketplace fields.
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 3 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
|
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:The PR only adds an optional field to an existing request model, improves doc comments, and adds a field to an existing source class, all reusing existing types and abstractions without new endpoints, persistence, auth changes, or external integrations.
wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…
david-ruiz-cko
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
POST /paymentsacceptsfallback_source, an alternative card source the platform attempts when the payment with the primary source fails. The Java SDK only modelled thefallback_source_usedresponse flag, so merchants could not send it.PaymentRequestnow exposes it asfallbackSource, typed as the existingRequestCardSource.RequestCardSourcewas also missingallow_update(Real-Time Account Updater), which the spec defines on both the primary card source and the fallback source, so the card used insourcegains it too.Changes
payments/request/PaymentRequest.java: addedfallbackSource(RequestCardSource). Doc comments completed:amountrange (max 9999999999), description and[Optional]for the deprecatedpaymentIpandmarketplace.payments/request/source/RequestCardSource.java: addedallowUpdate. Every doc comment rewritten from the spec:[Required]onnumber,expiryMonthandexpiryYear, min 1 max 12 onexpiryMonth, min 3 max 4 characters oncvv.PaymentRequestSerializationTest.java: new tests asserting the literalfallback_sourcekey with all 12 properties, a roundtrip, the swagger example, omission when null, andallow_updateon the primarysource.API Reference
POST /payments:PaymentRequest.fallback_source(PaymentRequestFallbackSource)PaymentRequestCardSource.allow_updateBreaking changes
None. Both fields are additive and optional; the
RequestCardSourcebuilder gains one optional setter.README
Not affected.