Repository navigation
Parse conditions before substituting values - #88
Merged
Merged
Conversation
Gubarz
marked this pull request as ready for review
October 13, 2026 04:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nested conditions produced conjunctions that the evaluator did not parse. Substituted operator text could also change the comparison. Split conjunctions and identify comparison operators in the template before substituting operands. Preserve existing whitespace rules.
Related issues
No linked issue.
Verification
Regression tests cover conjunctions and values containing operators. Three branch cases also pass through the built headless CLI.
Local checks passed on Go 1.27.1. The CI workflow uses Go 1.26.3.
Checklist
go build ./...andgo test ./...passgofmt -l .andgo vet ./...are cleancheatmd --lint examples/passes