Skip to content

fix: avoid breaking change#2

Open
peter-jerry-ye wants to merge 2 commits into
chawyehsu:mainfrom
peter-jerry-ye:main
Open

fix: avoid breaking change#2
peter-jerry-ye wants to merge 2 commits into
chawyehsu:mainfrom
peter-jerry-ye:main

Conversation

@peter-jerry-ye
Copy link
Copy Markdown

No description provided.

Comment thread encode.mbt
let mut m = @uint.max_value
for j = 0U; j < input_lenght; j = j + 1U {
let code = raw[j.reinterpret_as_int()].reinterpret_as_uint()
let code = raw[j.reinterpret_as_int()].to_uint()
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peter-jerry-ye Hi, I haven't been following moonbit's evolution closely, but I've been paying attention to the release notes from time to time. The last time I received a similar change, to_uint was a method that was replaced by reinterpret_as_uint and marked as obsolete1. However, the change you proposed is the complete opposite, which I don't understand. Could please you elaborate on this?

Footnotes

  1. https://github.com/chawyehsu/punycode.mbt/pull/1

@peter-jerry-ye
Copy link
Copy Markdown
Author

peter-jerry-ye commented May 15, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants