Skip to content

fix(vt): handle SCO restore cursor (CSI u) #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterSR wants to merge 1 commit into
base: main
Choose a base branch
from
+38 −0
Open

fix(vt): handle SCO restore cursor (CSI u) #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions vt/emulator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1753,6 +1753,38 @@ var cases = []struct {
pos: uv.Pos(0, 0),
},

// Save Cursor [ansi.DECSC] and Restore Cursor [ansi.DECRC]
{
name: "DECSC DECRC Restore Cursor Position",
w: 10, h: 1,
input: []string{
"\x1b[1;1H", // move to top-left
"\x1b[2J", // clear screen
"\x1b7", // save cursor position
"AAAA",
"\x1b8", // restore cursor position
"BB",
},
want: []string{"BBAA "},
pos: uv.Pos(2, 0),
},

// Save Current Cursor Position [ansi.SCOSC] and Restore Current Cursor Position [ansi.SCORC]
{
name: "SCOSC SCORC Restore Cursor Position",
w: 10, h: 1,
input: []string{
"\x1b[1;1H", // move to top-left
"\x1b[2J", // clear screen
"\x1b[s", // save cursor position (SCO)
"AAAA",
"\x1b[u", // restore cursor position (SCO)
"BB",
},
want: []string{"BBAA "},
pos: uv.Pos(2, 0),
},

// Tab Clear [ansi.TBC]
{
name: "TBC Clear Single Tab Stop",
Expand Down
6 changes: 6 additions & 0 deletions vt/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,4 +920,10 @@ func (e *Emulator) registerDefaultCsiHandlers() {

return true
})

e.RegisterCsiHandler('u', func(params ansi.Params) bool {
// Restore Current Cursor Position [ansi.SCORC]
e.scr.RestoreCursor()
return true
})
}