fix: stop padding multiline styled messages with trailing spaces - #228
Open
TastyHeadphones wants to merge 1 commit into
Open
TastyHeadphones wants to merge 1 commit into
TastyHeadphones wants to merge 1 commit into
Conversation
lipgloss pads every line to the widest line when Render gets a string with newlines, so styled multiline messages picked up huge trailing spaces. Render each line on its own instead. Fixes charmbracelet#187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lipgloss pads every line to the widest one when you
Rendera string that has newlines. We were styling the whole multiline message in one shot, so shorter lines got a bunch of trailing spaces (especially ugly with padded level styles).Now each line is styled on its own, same idea as the multiline field values path.
Fixes #187