Add Alibaba coding-plan provider#201
Closed
rpx99 wants to merge 2 commits intocharmbracelet:mainfrom
Closed
Conversation
rpx99
requested review from
meowgorithm and
raphamorim
and removed request for
a team
andreynering
added a commit
to charmbracelet/crush
that referenced
this pull request
Mar 4, 2026
andreynering
reviewed
Mar 4, 2026
Member
andreynering
left a comment
andreynering
left a comment
There was a problem hiding this comment.
Hi @rpx99, thanks for contributing!
I had to do a small change on Crush to be able to enter the API key and proceed:
You can use that branch to test as well.
I also made a few comments below.
| InferenceProviderMiniMax InferenceProvider = "minimax" | ||
| InferenceProviderMiniMaxChina InferenceProvider = "minimax-china" | ||
| InferenceProviderIoNet InferenceProvider = "ionet" | ||
| InferenceProviderAlibaba InferenceProvider = "alibaba" |
Member
There was a problem hiding this comment.
This also applies to the code. Let's do some renaming:
InferenceProviderAlibaba->InferenceProviderAlibabaCodingalibabaConfig->alibabaCodingConfigalibabaProvider->alibabaCodingProvideralibaba.json->alibaba-coding.json
aymanbagabas
approved these changes
Mar 4, 2026
Adds a new Alibaba provider config and registers it in the provider registry.\n\n- add internal/providers/configs/alibaba.json\n- register provider embed+factory in internal/providers/providers.go\n- add InferenceProviderAlibaba to known providers\n\nRefs charmbracelet#200
Align naming with coding-plan-specific endpoint and simplify model names.
rpx99
force-pushed
the
feat/alibaba-provider-200
branch
from
3175428 to
f721174
Compare
Author
|
https://github.com/charmbracelet/catwalk/pull/203Am 05.03.2026 15:10 schrieb Wallace Gibbon ***@***.***>:
@wallacegibbon commented on this pull request.
In internal/providers/configs/alibaba-coding.json:
@@ -0,0 +1,163 @@
+{
+ "name": "Alibaba Coding Plan",
+ "id": "alibaba",
+ "type": "openai-compat",
+ "api_key": "$ALIBABA_API_KEY",
+ "api_endpoint": "https://coding-intl.dashscope.aliyuncs.com/v1",
The intl endpoint do works, but it's pointing to a Singapore IP address, which is much slower to access in China. Users will need to edit their crush.json to use dashscope.aliyuncs.com in the end if it's not supported by Crush directly.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
Closing in favor of #203 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new Alibaba provider config and registers it in the provider registry: