Skip to content

Fixed deprecation warning #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddaddy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed deprecation warning #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions Sources/XlsxReaderWriter/XlsxReaderWriter/BRAPlatformSpecificDefines.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,22 +50,24 @@ NS_INLINE BOOL BRANativeEdgeInsetsEqualToEdgeInsets(NSEdgeInsets a, NSEdgeInsets
NS_INLINE NSData* BRANativeImagePNGRepresentation(NSImage *image) {
// Create a bitmap representation from the current image

[image lockFocus];
NSBitmapImageRep *bitmapRep = [[NSBitmapImageRep alloc] initWithFocusedViewRect:NSMakeRect(0, 0, image.size.width, image.size.height)];
[image unlockFocus];
CGImageRef cgImage = [image CGImageForProposedRect:NULL context:nil hints:nil];
if (!cgImage) { return nil; }

NSBitmapImageRep *bitmapRep = [[NSBitmapImageRep alloc] initWithCGImage:cgImage];

return [bitmapRep representationUsingType:NSPNGFileType properties:@{}];
return [bitmapRep representationUsingType:NSBitmapImageFileTypePNG properties:@{}];
}


NS_INLINE NSData* BRANativeImageJPEGRepresentation(NSImage *image, CGFloat quality) {
// Create a bitmap representation from the current image

[image lockFocus];
NSBitmapImageRep *bitmapRep = [[NSBitmapImageRep alloc] initWithFocusedViewRect:NSMakeRect(0, 0, image.size.width, image.size.height)];
[image unlockFocus];
CGImageRef cgImage = [image CGImageForProposedRect:NULL context:nil hints:nil];
if (!cgImage) { return nil; }

NSBitmapImageRep *bitmapRep = [[NSBitmapImageRep alloc] initWithCGImage:cgImage];

return [bitmapRep representationUsingType:NSJPEGFileType properties:@{NSImageCompressionFactor:@(quality)}];
return [bitmapRep representationUsingType:NSBitmapImageFileTypeJPEG properties:@{NSImageCompressionFactor:@(quality)}];
}


Expand Down