Fix/nfc launch - #470
Open
somq wants to merge 11 commits into
Open
Conversation
Currently attempting to write a tag will fail because the tag information is not persisted in `savedIntent` as part of the reader session. This only affects Android.
* To play nice with other plugins which may define the `continueUserActivity` method in AppDelegate
The plugin works perfectly in all devices except for Andorid 12.
I get following error
```
Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent
```
I see the problem is in `createPendingIntent` Method
```
private void createPendingIntent() {
if (pendingIntent == null) {
Activity activity = getActivity();
Intent intent = new Intent(activity, activity.getClass());
intent.addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP | Intent.FLAG_ACTIVITY_CLEAR_TOP);
pendingIntent = PendingIntent.getActivity(activity, 0, intent, 0); // Problem in the last param here
}
}
```
This PR solves the problem by just adding the requried flag which also works for lower android versions
see chariotsolutions#457 (comment) ment-988285150
|
Note: This PR builds up on top of parts from PR #460. |
This was referenced Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #457 (comment)