Fix configured memory path normalization#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
memoryDir: "~/.pi/agent/pi-hermes-memory"config bug from #42 by normalizing configured storage paths before startup uses them.What changed
memoryDirduring config loading so~resolves to the user home directory instead of becoming a literal repo-local pathmemoryDirvalues against~/.pi/agentso config behavior is stable and not dependent on the current working directoryprojectsMemoryDirconstrained to a single safe directory segment under~/.pi/agent, which matches the existing config contract and avoids opening a partially supported nested-path modememoryDir, so custom global memory roots do not break legacy project migration or project memory discovery~expansion, relative path normalization, unsafeprojectsMemoryDirrejection, and the custom-global-root migration/sync behaviorVerification
npm run checknpx tsx --test tests/config.test.tsnpx tsx --test tests/project-memory-migration.test.tsprojectsMemoryDirhandlingNotes
npm testis still blocked in this environment by the existingbetter-sqlite3vs Node ABI mismatch in SQLite-backed tests; this branch does not introduce a new path-related test failure there.Fixes #42