Add customEndAtSeconds and uuid fields to Period#38
Conversation
In transition, those fields are being added to allow to customize when a period should end and the uuid field is useful to save the period in the database.
|
DO NOT MERGE YET I'm putting the patch here, but I'd like to add some unit tests around it and wait to see if the uuid field is absolutely necessary (since it goes from database to the cache, but it does not need to be the other way around...) |
|
@tahini Is this still relevant ? |
|
Still relevant I guess, but didn't have time to look into it. Is the period even necessary? Or could we just keep trips hours? |
|
@tahini, we should just do this. Having the capnp file out of sync does not make sense. Either we remove them from the transition side or we merge this in TrRouting. |
|
@greenscientist There's still the question of what to do with those fields. Is there any use case to have the capnp file have more data that what is needed in trRouting? Or do we consider those files are "just" a cache and can/should contain the minimal information required to run? (especially if we plan to store them along with calculations for later re-use, it goes towards minimal information) |
|
From the TrRouting perspective, this file should be in sync. |
In transition, those fields are being added to allow to customize when a
period should end and the uuid field is useful to save the period in the
database.