Add Token.import_reissuable_token_script_pubkey#214
Merged
Conversation
rantan
force-pushed
the
issue_from_specified_pubkey
branch
from
3cfe185 to
0f57437
Compare
azuchi
requested changes
Jul 31, 2025
azuchi
reviewed
Jul 31, 2025
azuchi
left a comment
azuchi
left a comment
Contributor
There was a problem hiding this comment.
追加したメソッドで、Glueby::Contract::AR::ReissuableTokenのレコードが作られることで、#reissue! が機能するようになります。
この期待する動作について機能テストを追加できますか？
to import reissuable token from outside of Glueby
rantan
force-pushed
the
issue_from_specified_pubkey
branch
from
0f57437 to
fb8d7af
Compare
rantan
changed the title
Contributor
Author
機能テストを追加しました。 |
azuchi
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
外部で発行された再発行可能トークンをインポートして扱うためのメソッドを追加しました。
追加したメソッドで、Glueby::Contract::AR::ReissuableTokenのレコードが作られることで、#reissue! が機能するようになります。
すでに #parse_from_payload で同様のことができますが、#to_payload で出力された値を前提とするため、glueby 以外で発行された再発行可能トークンのインポートとしては扱いにくいため、新しいインターフェースを追加します。