This repository was archived by the owner on Apr 3, 2023. It is now read-only.
Add support for parsing submodules#146
Open
pswaminathan wants to merge 3 commits intocgrindel:mainfrom
Open
Conversation
385747c to
35cc258
Compare
Owner
|
Sorry for the radio silence on this end. I am out on vacation for the next week and a half. I will take a look at this PR when I am back online. |
Owner
|
@pswaminathan I am so sorry for the delay in reviewing this. It fell off of my radar. Thank you for sending it. I think that the submodule parsing should run through the same parsing code as the module parsing. Since we cannot rely on recursive functions, I am thinking that we implement it like so:
What do you think? I am working on an implementation. I will send it out for review when I have something that works. |
Owner
|
@pswaminathan I added my first pass at submodule parsing in #169. If that looks reasonable to you, do you think we should close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.