fix: prevent Enter key from inserting newline before submit#346
Open
hakonharnes wants to merge 1 commit intocgoinglove:mainfrom
Open
fix: prevent Enter key from inserting newline before submit#346hakonharnes wants to merge 1 commit intocgoinglove:mainfrom
hakonharnes wants to merge 1 commit intocgoinglove:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the cgoinglove's projects Team on Vercel. A member of the Team first needs to authorize it. |
hakonharnes
force-pushed
the
fix/enter-key-newline-insertion
branch
from
889cbb7 to
4f1ff3d
Compare
hakonharnes
force-pushed
the
fix/enter-key-newline-insertion
branch
from
4f1ff3d to
cf9b7fa
Compare
hakonharnes
added a commit
to hakonharnes/better-chatbot
that referenced
this pull request
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the cursor is in the middle of text (e.g., "hello (cursor) world") and pressing Enter to submit, the message would be sent as "hello \nworld" instead of "hello world". This happens because the React
onKeyDownhandler onEditorContentfires after Tiptap has already processed the Enter key and inserted a newline.This PR moves the Enter key handling to Tiptap's
handleKeyDownin editorProps, which intercepts keystrokes before the editor processes them.