Repository navigation
fix: use SPDX license expression so setuptools 77+ can build - #40
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #38.
SPDX:
pyproject.tomlkeptlicense = "MIT"but also listed the superseded Trove classifierLicense :: OSI Approved :: MIT License. Current setuptools rejects that combination (InvalidConfigError), souv pip install -e '.[dev,integrations]'failed. Drop the classifier and requiresetuptools>=77(SPDX license expressions).Ruff pip-cache teardown: already landed on
mainin #37 (60c3c4d— standaloneruff.ymlno longer enables pip cache while installing with--no-cache-dir). This PR does not retouch that workflow.Verified:
pip install -e '.[dev,integrations]'succeeds on setuptools 84tests/test_pyproject_metadata.pylocks the SPDX-not-classifier contractruff check/ruff format --checkon the new test fileNo parser/CLI behavior change.