Repository navigation
Conversation
|
PR template check (blocking) This PR is not a complete fill of
This check fails the job. Copy |
Owner
Author
|
Where did this come from haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch naming (required for agent-opened PRs)
Before opening a PR, create the head branch with the driver-matched prefix.
Hooks and
utils/agent_identity.pyenforce this allowlist; casual / generic names are not a substitute.claude/<feature>claude/telegram-media-auditcodex/<feature>codex/verify-dep-guardgrok/<feature>grok/pr-template-branch-ruleskimi/<feature>kimi/docs-syncCyClaw/<feature>-<YYYYMMDD>orcyclaw/<feature>CyClaw/harness-timeout-20260805agent/<feature>agent/launcher-browser-parityRules for agents:
agent/when the driver is known (Claude →claude/, Grok →grok/, etc.).<feature>must be short, kebab-case, and describe the change (no spaces, no leading-).git branch -m <prefix>/<feature>.Also allowed by hooks (non-feature):
main,dependabot/*,renovate/*,release/*,hotfix/*.Title
Use this format:
[prefix] - Short descriptive sentence of the changeRecommended prefixes (pick the most relevant):
[invariant]•[governance]•[fsconnect]•[agentic]•[rag]•[security]•[docs]•[infra]•[fix]•[feat]Example:
[governance] - add two-phase audit + quota enforcement to fsconnect write pathProposed changes
Describe the big picture of your changes here. Explain why maintainers should accept this PR.
If it fixes a bug or resolves a feature request, link the issue.
Invariant / Governance Impact (required for any change touching core paths):
Types of changes
What types of changes does your code introduce to CyClaw?
Put an
xin every box that applies. Other is only for a change that fits none of the named boxes. Do not use Documentation update or Other for a security, dependency, or CI change.Optional free-text scope note (recommended):
Core graph/gate/soul path | Out-of-band agentic/fsconnect/sync layer | RAG retrieval/sanitization | Docs + audits | Infrastructure / CI only
Benefits / why
Risks to monitor
Checklist
Put an
xin the boxes that apply. You can fill these out after creating the PR. If you're unsure about any item, ask before opening the PR.docs/THREAT_MODEL.md,INVARIANTS.mdandSECURITY.md(and any relevant Phase docs)GROK_API_KEY=dummy pytest tests/ -q --tb=short, andbash .claude/skills/CyClaw-Sandbox/verify.shfor core RAG/agentic paths) and passes with no regressionsFurther comments
If this is a relatively large, complex, or core-path change, kick off the discussion here in technical tone. The plain-language summary of the whole PR goes in the required
## ELI5at the very end, not here.For changes touching
graph.py,gate.py, soul paths, RAG retrieval/sanitization, or agentic subsystems, include:## ELI5, below)Examples of what good "Further comments" look like for core changes:
Notes for contributors (including solo maintainer / multi-agent PRs):
agentic/,sync/,.claude/) may use a lighter checklist, but still need Benefits + Risks + the relevant items.main.Suggested merge order of open PRs
Required on every PR, including a lone one (write "independent, only open PR"). Keep every entry to 3 short lines so it reads on a phone: the PR, its impact, the action.
Impact:line.Safe ✅(trial merge clean against currentmain),Dirty ⚠️(conflicts, or stacked on something unmerged),Blocked ⛔(red CI, unresolved blocking review, or still a draft that is not ready).mainSHA. Locally:git fetch origin && git switch --detach origin/main && git merge --no-commit --no-ff origin/<branch>, thengit merge --abort. A "Safe" is only true until the next merge intomain; re-run it right before merging.git rebase --onto origin/main <old-parent-tip> <branch>for a stacked child whose parent was squash-merged) over GitHub's "Update branch" button. Force-pushing a rebased branch is fine only on a branch that is yours alone, with--force-with-lease, and with the owner's OK.ELI5
Required on every PR, and it must stay the last heading in the body (
pr-template-check.ymlenforces both). The body's last non-blank line is the stamp below, nothing after it; refresh it whenever you edit the body.Explain the whole diff against
main, not just the first commit. Re-read it whenever a later commit changes what the PR does. Plain words, no jargon you would not say out loud, but keep the specifics:Last updated: YYYY-MM-DD HH:MM ET